Skip to content

Use params.text_size in _show_geojson#131

Merged
joshqsumner merged 2 commits into
mainfrom
130-pull-pcvparams-for-plotting
May 11, 2026
Merged

Use params.text_size in _show_geojson#131
joshqsumner merged 2 commits into
mainfrom
130-pull-pcvparams-for-plotting

Conversation

@k034b363
Copy link
Copy Markdown
Contributor

@k034b363 k034b363 commented Apr 28, 2026

Describe your changes
The helper function _show_geojson uses a hard-coded text size for displaying plot labels on debugs. This PR updates it to pull PlantCV's params.text_size instead.

Type of update

  • New feature or feature enhancement

Associated issues
Closes #130

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv-geospatial/mkdocs.yml
  • Changes to function input/output signatures added to changelog.md
  • Code reviewed
  • PR approved

@k034b363 k034b363 linked an issue Apr 28, 2026 that may be closed by this pull request
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Apr 28, 2026

DeepSource Code Review

We reviewed changes in 9a9bf32...263261b on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Apr 29, 2026 1:37p.m. Review ↗
Code coverage Apr 29, 2026 1:40p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
100%
Python
100%
100%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Copy link
Copy Markdown
Contributor

@joshqsumner joshqsumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@joshqsumner joshqsumner merged commit 3b73548 into main May 11, 2026
5 checks passed
@joshqsumner joshqsumner deleted the 130-pull-pcvparams-for-plotting branch May 11, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pull pcv.params for plotting

2 participants